[ 
https://issues.apache.org/jira/browse/STORM-1916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15365118#comment-15365118
 ] 

ASF GitHub Bot commented on STORM-1916:
---------------------------------------

Github user d2r commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1507#discussion_r69813914
  
    --- Diff: 
storm-core/src/jvm/org/apache/storm/daemon/supervisor/workermanager/DefaultWorkerManager.java
 ---
    @@ -347,14 +347,25 @@ protected String getWorkerClassPath(String stormJar, 
Map stormConf) {
             List<String> topoClasspath = new ArrayList<>();
             Object object = stormConf.get(Config.TOPOLOGY_CLASSPATH);
     
    +        // Will be populated only if STORM_USER_CLASSPATH_FIRST_ENABLED is 
set on Nimbus.
    +        // Allowed for extreme debugging.
    +        Object topologyClasspathFirst = 
stormConf.get(Config.TOPOLOGY_CLASSPATH_FIRST);
    +        List<String> firstClasspathList = new ArrayList<>();
    +        if(topologyClasspathFirst instanceof List) {
    +           firstClasspathList.addAll((List<String>)topologyClasspathFirst);
    --- End diff --
    
    minor: indent to 4 spaces


> Add ability for worker-first classpath
> --------------------------------------
>
>                 Key: STORM-1916
>                 URL: https://issues.apache.org/jira/browse/STORM-1916
>             Project: Apache Storm
>          Issue Type: Improvement
>            Reporter: Kyle Nusbaum
>            Assignee: Kyle Nusbaum
>
> Debugging in multi-tenant environments can be difficult, and having the 
> ability to override the classpath can be helpful. We want a topology config 
> that specifies an overriding classpath for a given topology. This config is 
> disabled by default since users overriding the classpath is dangerous in a 
> multi-tenant environment. The config can be temporarily enabled on Nimbus to 
> allow submission of topologies with overridden classpaths. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to