[ 
https://issues.apache.org/jira/browse/STORM-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15370063#comment-15370063
 ] 

ASF GitHub Bot commented on STORM-1277:
---------------------------------------

Github user harshach commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1445#discussion_r70193545
  
    --- Diff: storm-core/src/jvm/org/apache/storm/executor/Executor.java ---
    @@ -0,0 +1,567 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.storm.executor;
    +
    +import clojure.lang.IFn;
    +import com.google.common.annotations.VisibleForTesting;
    +import com.google.common.collect.Lists;
    +import com.lmax.disruptor.EventHandler;
    +import com.lmax.disruptor.dsl.ProducerType;
    +import java.io.IOException;
    +import java.net.UnknownHostException;
    +import java.util.concurrent.atomic.AtomicBoolean;
    +import java.util.concurrent.atomic.AtomicReference;
    +import org.apache.storm.Config;
    +import org.apache.storm.Constants;
    +import org.apache.storm.StormTimer;
    +import org.apache.storm.cluster.ClusterStateContext;
    +import org.apache.storm.cluster.ClusterUtils;
    +import org.apache.storm.cluster.DaemonType;
    +import org.apache.storm.cluster.IStormClusterState;
    +import org.apache.storm.daemon.GrouperFactory;
    +import org.apache.storm.daemon.StormCommon;
    +import org.apache.storm.daemon.Task;
    +import org.apache.storm.executor.bolt.BoltExecutor;
    +import org.apache.storm.executor.error.IReportError;
    +import org.apache.storm.executor.error.ReportError;
    +import org.apache.storm.executor.error.ReportErrorAndDie;
    +import org.apache.storm.executor.spout.SpoutExecutor;
    +import org.apache.storm.generated.Bolt;
    +import org.apache.storm.generated.DebugOptions;
    +import org.apache.storm.generated.Grouping;
    +import org.apache.storm.generated.SpoutSpec;
    +import org.apache.storm.generated.StormTopology;
    +import org.apache.storm.grouping.LoadAwareCustomStreamGrouping;
    +import org.apache.storm.metric.api.IMetric;
    +import org.apache.storm.metric.api.IMetricsConsumer;
    +import org.apache.storm.stats.BoltExecutorStats;
    +import org.apache.storm.stats.CommonStats;
    +import org.apache.storm.stats.SpoutExecutorStats;
    +import org.apache.storm.stats.StatsUtil;
    +import org.apache.storm.task.WorkerTopologyContext;
    +import org.apache.storm.tuple.AddressedTuple;
    +import org.apache.storm.tuple.Fields;
    +import org.apache.storm.tuple.Tuple;
    +import org.apache.storm.tuple.TupleImpl;
    +import org.apache.storm.tuple.Values;
    +import org.apache.storm.utils.ConfigUtils;
    +import org.apache.storm.utils.DisruptorBackpressureCallback;
    +import org.apache.storm.utils.DisruptorQueue;
    +import org.apache.storm.utils.Time;
    +import org.apache.storm.utils.Utils;
    +import org.apache.storm.utils.WorkerBackpressureThread;
    +import org.json.simple.JSONValue;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import java.util.*;
    --- End diff --
    
    can we not do wildcard imports


> port backtype.storm.daemon.executor to java
> -------------------------------------------
>
>                 Key: STORM-1277
>                 URL: https://issues.apache.org/jira/browse/STORM-1277
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-core
>            Reporter: Robert Joseph Evans
>            Assignee: Cody
>              Labels: java-migration, jstorm-merger
>
> https://github.com/apache/storm/tree/jstorm-import/jstorm-core/src/main/java/com/alibaba/jstorm/task
>  kind of.  Tasks and executors are combined in jstorm.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to