[
https://issues.apache.org/jira/browse/STORM-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15370079#comment-15370079
]
ASF GitHub Bot commented on STORM-1277:
---------------------------------------
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/1445#discussion_r70194730
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -77,7 +78,7 @@ public static StormCommon setInstance(StormCommon common)
{
return oldInstance;
}
- private static final Logger LOG =
LoggerFactory.getLogger(StormCommon.class);
+ private static final Logger LOG = getLogger(StormCommon.class);
--- End diff --
lets keep it to LoggerFactory.getLogger given that we are using the same
way everywhere else.
> port backtype.storm.daemon.executor to java
> -------------------------------------------
>
> Key: STORM-1277
> URL: https://issues.apache.org/jira/browse/STORM-1277
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-core
> Reporter: Robert Joseph Evans
> Assignee: Cody
> Labels: java-migration, jstorm-merger
>
> https://github.com/apache/storm/tree/jstorm-import/jstorm-core/src/main/java/com/alibaba/jstorm/task
> kind of. Tasks and executors are combined in jstorm.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)