[
https://issues.apache.org/jira/browse/STORM-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399188#comment-15399188
]
ASF GitHub Bot commented on STORM-2006:
---------------------------------------
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1595#discussion_r72779300
--- Diff: storm-core/src/jvm/org/apache/storm/metric/SystemBolt.java ---
@@ -156,7 +219,103 @@ private void registerMetrics(TopologyContext context,
Map<String, String> metric
@Override
public void execute(Tuple input) {
- throw new RuntimeException("Non-system tuples should never be sent
to __system bolt.");
--- End diff --
can we check that the incoming stream is METRICS_STREAM and throw same
exception if its not?
> Storm metrics feature improvement: support per-worker level metrics
> aggregation
> -------------------------------------------------------------------------------
>
> Key: STORM-2006
> URL: https://issues.apache.org/jira/browse/STORM-2006
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Affects Versions: 1.1.0
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
>
> Storm provides per-task level metrics which could be huge when topology has a
> number of tasks.
> Task level metric is useful for determining load balance between tasks, but
> it doesn't need to be time-series fashion.
> Before introducing topology level component like TopologyMaster for JStorm,
> we can utilize SystemBolt to aggregate task level metrics to per-worker level
> metrics.
> We should provide options and this feature should be turned off by default to
> keep backward compatibility.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
