Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76460236
--- Diff:
storm-core/src/jvm/org/apache/storm/container/ResourceIsolationInterface.java
---
@@ -56,4 +64,13 @@
*/
List<String> getLaunchCommandPrefix(String workerId);
+ /**
+ * Get the list of PIDs currently in an isolated container
+ * @param workerId the id of the worker to get these for
+ * @return the set of PIDs, this will be combined with
+ * other ways of getting PIDs. An Empty set or null if
+ * no PIDs are found.
+ * @throws IOException on any error
+ */
--- End diff --
Let's just return a Set and have it be empty if no PIDs are found. Callers
then don't have to check both cases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
