Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76460431
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupManager.java ---
@@ -211,4 +209,15 @@ public void releaseResourcesForWorker(String workerId)
{
public void close() throws IOException {
this.center.deleteCgroup(this.rootCgroup);
}
+
+ @Override
+ public Set<Long> getRunningPIDs(String workerId) throws IOException {
+ CgroupCommon workerGroup = new CgroupCommon(workerId,
this.hierarchy, this.rootCgroup);
+ if (!this.rootCgroup.getChildren().contains(workerGroup)) {
+ LOG.warn("cgroup {} doesn't exist!", workerGroup);
+ return null;
+ }
+ Set<Long> ret = new HashSet<>();
--- End diff --
`ret` isn't used here, but we could return an empty set instead of null.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
