Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77294478
--- Diff: storm-core/src/jvm/org/apache/storm/utils/ConfigUtils.java ---
@@ -512,6 +463,10 @@ public static String workerTmpRoot(Map conf, String
id) {
public static String workerPidPath(Map conf, String id, String pid) {
return (workerPidsRoot(conf, id) + FILE_SEPARATOR + pid);
}
+
+ public static String workerPidPath(Map<String, Object> conf, String
id, long pid) {
+ return (workerPidsRoot(conf, id) + FILE_SEPARATOR + pid);
--- End diff --
Nit: might be better to call workerPidPath(conf, id, String.valueOf(pid))
or vice versa.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
