Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77321291
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1990,31 +1995,26 @@ protected void forceDeleteImpl(String path) throws
IOException {
}
/**
- * Creates a symbolic link to the target
+ * Creates a symbolic link to the target and force the creation if the
target already exists
* @param dir the parent directory of the link
* @param targetDir the parent directory of the link's target
- * @param filename the file name of the link
* @param targetFilename the file name of the links target
+ * @param filename the file name of the link
* @throws IOException
*/
- public static void createSymlink(String dir, String targetDir,
- String filename, String targetFilename) throws IOException {
+ public static void forceCreateSymlink(String dir, String targetDir,
--- End diff --
The sequence of parameters have been swapped: targetFilename and filename.
Since parameters of parent directory are link and target, it would be
natural to keep that sequence to filename, too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
