Github user sachingsachin commented on a diff in the pull request:
https://github.com/apache/storm/pull/1751#discussion_r86189208
--- Diff:
external/sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/utils/SerdeUtils.java
---
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.sql.runtime.utils;
+
+import static org.apache.commons.lang.StringUtils.isNotEmpty;
+
+import com.google.common.base.Preconditions;
+import org.apache.avro.util.Utf8;
+import org.apache.storm.spout.Scheme;
+import org.apache.storm.sql.runtime.IOutputSerializer;
+import org.apache.storm.sql.runtime.serde.avro.AvroScheme;
+import org.apache.storm.sql.runtime.serde.avro.AvroSerializer;
+import org.apache.storm.sql.runtime.serde.json.JsonScheme;
+import org.apache.storm.sql.runtime.serde.json.JsonSerializer;
+import org.apache.storm.utils.Utils;
+
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Properties;
+
+public final class SerdeUtils {
+ public static Scheme getScheme(String inputFormatClass, Properties
properties, List<String> fieldNames) {
+ Scheme scheme;
+ if (isNotEmpty(inputFormatClass)) {
+ switch (inputFormatClass) {
+ case "org.apache.storm.sql.runtime.serde.json.JsonScheme" :
+ scheme = new JsonScheme(fieldNames);
+ break;
+ case "org.apache.storm.sql.runtime.serde.avro.AvroScheme" :
+ String schemaString =
properties.getProperty("avro.schema");
+ Preconditions.checkArgument(isNotEmpty(schemaString),
"avro.schema can not be empty");
+ scheme = new AvroScheme(schemaString, fieldNames);
+ break;
+ default:
+ scheme = Utils.newInstance(inputFormatClass);
+ }
+ } else {
+ //use JsonScheme as the default scheme
+ scheme = new JsonScheme(fieldNames);
+ }
+ return scheme;
+ }
+
+ public static IOutputSerializer getSerializer(String
outputFormatClass, Properties properties, List<String> fieldNames) {
+ IOutputSerializer serializer;
+ if (isNotEmpty(outputFormatClass)) {
+ switch (outputFormatClass) {
+ case
"org.apache.storm.sql.runtime.serde.json.JsonSerializer" :
+ serializer = new JsonSerializer(fieldNames);
+ break;
+ case
"org.apache.storm.sql.runtime.serde.avro.AvroSerializer" :
+ String schemaString =
properties.getProperty("avro.schema");
+ Preconditions.checkArgument(isNotEmpty(schemaString),
"avro.schema can not be empty");
+ serializer = new AvroSerializer(schemaString,
fieldNames);
+ break;
+ default:
+ serializer = Utils.newInstance(outputFormatClass);
+ }
+ } else {
+ //use JsonSerializer as the default serializer
+ serializer = new JsonSerializer(fieldNames);
+ }
+ return serializer;
+ }
+
+ public static Map convertAvroUtf8Map(Map<Object, Object> value) {
+ Map<Object, Object> map = new HashMap<>();
+ for (Map.Entry<Object, Object> entry : value.entrySet()) {
+ // Avro only allows maps with Strings for keys, so we only
have to worry
+ // about deserializing the values
+ Object key = entry.getKey().toString();
+ Object val = entry.getValue();
+
+ if (val instanceof Utf8) {
+ map.put(key, val.toString());
+ } else if (val instanceof Map<?, ?>) {
+ map.put(key, convertAvroUtf8Map((Map<Object, Object>)val));
+ } else {
+ map.put(key, val);
--- End diff --
Same comment about arrays/sets of Utf8 objects. We need an if/else for
those as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
