Github user sachingsachin commented on a diff in the pull request:
https://github.com/apache/storm/pull/1751#discussion_r86188870
--- Diff:
external/sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/serde/avro/AvroScheme.java
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.sql.runtime.serde.avro;
+
+import org.apache.avro.Schema;
+import org.apache.avro.generic.GenericDatumReader;
+import org.apache.avro.generic.GenericRecord;
+import org.apache.avro.io.BinaryDecoder;
+import org.apache.avro.io.DatumReader;
+import org.apache.avro.io.DecoderFactory;
+import org.apache.avro.util.Utf8;
+import org.apache.storm.spout.Scheme;
+import org.apache.storm.sql.runtime.utils.SerdeUtils;
+import org.apache.storm.tuple.Fields;
+import org.apache.storm.utils.Utils;
+
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+
+public class AvroScheme implements Scheme {
+ private final String schemaString;
+ private final List<String> fieldNames;
+ private final CachedSchemas schemas;
+
+ public AvroScheme(String schemaString, List<String> fieldNames) {
+ this.schemaString = schemaString;
+ this.fieldNames = fieldNames;
+ this.schemas = new CachedSchemas();
+ }
+
+ @Override
+ public List<Object> deserialize(ByteBuffer ser) {
+ try {
+ Schema schema = schemas.getSchema(schemaString);
+
+ DatumReader<GenericRecord> reader = new GenericDatumReader<>(schema);
+ BinaryDecoder decoder =
DecoderFactory.get().binaryDecoder(Utils.toByteArray(ser), null);
+ GenericRecord record = reader.read(null, decoder);
+
+ ArrayList<Object> list = new ArrayList<>(fieldNames.size());
+ for (String field : fieldNames) {
+ Object value = record.get(field);
+ // Avro strings are stored using a special Avro type instead of
using Java primitives
+ if (value instanceof Utf8) {
+ list.add(value.toString());
+ } else if (value instanceof Map<?, ?>) {
+ Map<Object, Object> map =
SerdeUtils.convertAvroUtf8Map((Map<Object, Object>)value);
+ list.add(map);
+ } else {
+ list.add(value);
--- End diff --
Do we need to check array type containers too for Utf8-to-String
conversion? Example: array or set of Utf-8 objects? That should cover all the
cases IMO
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
