Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1679#discussion_r86893341
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -266,19 +266,22 @@ private void doSeekRetriableTopicPartitions() {
if (offsetAndMeta != null) {
kafkaConsumer.seek(rtp, offsetAndMeta.offset() + 1); //
seek to the next offset that is ready to commit in next commit cycle
} else {
- kafkaConsumer.seekToEnd(toArrayList(rtp)); // Seek to
last committed offset
+ kafkaConsumer.seek(rtp, acked.get(rtp).committedOffset +
1); // Seek to last committed offset
}
}
}
// ======== emit =========
private void emit() {
- emitTupleIfNotEmitted(waitingToEmit.next());
- waitingToEmit.remove();
+ while(!emitTupleIfNotEmitted(waitingToEmit.next()) &&
waitingToEmit.hasNext()) {
--- End diff --
@jfenc91 I believe that there is no need for this while loop here. I ran
all your test cases without it and they all pass. Unless there is a particular
reason to have this loop in here, I would suggest that you remove it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
