Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1825#discussion_r92848870
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -360,18 +411,22 @@ private void subscribeKafkaConsumer() {
kafkaConsumer = new
KafkaConsumer<>(kafkaSpoutConfig.getKafkaProps(),
kafkaSpoutConfig.getKeyDeserializer(),
kafkaSpoutConfig.getValueDeserializer());
- if (kafkaSpoutStreams instanceof KafkaSpoutStreamsNamedTopics) {
- final List<String> topics = ((KafkaSpoutStreamsNamedTopics)
kafkaSpoutStreams).getTopics();
- kafkaConsumer.subscribe(topics, new
KafkaSpoutConsumerRebalanceListener());
- LOG.info("Kafka consumer subscribed topics {}", topics);
- } else if (kafkaSpoutStreams instanceof
KafkaSpoutStreamsWildcardTopics) {
- final Pattern pattern = ((KafkaSpoutStreamsWildcardTopics)
kafkaSpoutStreams).getTopicWildcardPattern();
- kafkaConsumer.subscribe(pattern, new
KafkaSpoutConsumerRebalanceListener());
- LOG.info("Kafka consumer subscribed topics matching wildcard
pattern [{}]", pattern);
+ if (manualPartitionAssignment) {
+ doRefreshPartitions();
--- End diff --
Nit, but it would probably be good to log which topic is subscribed as well
here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
