Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1825#discussion_r92845884
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -236,6 +257,35 @@ private boolean poll() {
return poll;
}
+ private void refreshPartitionIfNeeded() {
+ if (!manualPartitionAssignment ||
!partitionRefreshTimer.isExpiredResetOnTrue()) return;
+ doRefreshPartitions();
+ }
+
+ private void doRefreshPartitions() {
+ KafkaSpoutStreamsNamedTopics streams =
KafkaSpoutStreamsNamedTopics.class.cast(kafkaSpoutStreams);
--- End diff --
I think you can still support wildcard topics via KafkaConsumer.listTopics.
If it isn't added in this PR, we should make an issue for it at least.
Also nit: Why are you using class.cast instead of C-style cast?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
