Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96897291
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -325,15 +310,19 @@ private boolean
emitTupleIfNotEmitted(ConsumerRecord<K, V> record) {
} else {
boolean isScheduled = retryService.isScheduled(msgId);
if (!isScheduled || retryService.isReady(msgId)) { // not
scheduled <=> never failed (i.e. never emitted) or ready to be retried
- final List<Object> tuple =
tuplesBuilder.buildTuple(record);
- kafkaSpoutStreams.emit(collector, tuple, msgId);
+ final List<Object> tuple =
kafkaSpoutConfig.getTranslator().apply(record);
+ if (tuple instanceof KafkaTuple) {
--- End diff --
The javadocs for RecordTranslator state.
```
* @return the objects in the tuple. Return a {@link KafkaTuple}
* if you want to route the tuple to a non-default stream
```
All of the provided implementations support this. Both Simple and ByTopic,
by way of the SimpleRecordTranslator.
I will add a section in the docs to talk about this, but it only really
matters if you are writing your own record translator from scratch, instead of
using the built in ones that should cover the vast majority of the use cases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
