Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r96908178
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/TopicPartitionComparator.java
---
@@ -1,16 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
package org.apache.storm.kafka.spout;
-import org.apache.kafka.common.TopicPartition;
-
import java.util.Comparator;
+import org.apache.kafka.common.TopicPartition;
+
public class TopicPartitionComparator implements
Comparator<TopicPartition> {
- @Override
- public int compare(TopicPartition o1, TopicPartition o2) {
- if (!o1.topic().equals(o2.topic())) {
- return o1.topic().compareTo(o2.topic());
- } else {
- return o1.partition() - o2.partition();
- }
- }
+ public static final TopicPartitionComparator INSTANCE = new
TopicPartitionComparator();
--- End diff --
I'm not sure we need to guarantee it. The old code had the INSTANCE where
it was used, I moved it here in hopes that others might use it. I could make
the constructor private if we really want it to be a singleton, but I don't
think it is a requirement.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
