Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r96924990 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/trident/TridentKafkaState.java --- @@ -0,0 +1,114 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.storm.kafka.trident; + +import org.apache.storm.task.OutputCollector; +import org.apache.storm.topology.FailedException; +import org.apache.kafka.clients.producer.KafkaProducer; +import org.apache.kafka.clients.producer.ProducerRecord; +import org.apache.kafka.clients.producer.RecordMetadata; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import org.apache.storm.kafka.trident.mapper.TridentTupleToKafkaMapper; +import org.apache.storm.kafka.trident.selector.KafkaTopicSelector; +import org.apache.storm.trident.operation.TridentCollector; +import org.apache.storm.trident.state.State; +import org.apache.storm.trident.tuple.TridentTuple; + +import java.util.ArrayList; +import java.util.List; +import java.util.Properties; +import java.util.concurrent.ExecutionException; +import java.util.concurrent.Future; + +public class TridentKafkaState implements State { + private static final Logger LOG = LoggerFactory.getLogger(TridentKafkaState.class); + + private KafkaProducer producer; + private OutputCollector collector; + + private TridentTupleToKafkaMapper mapper; + private KafkaTopicSelector topicSelector; + + public TridentKafkaState withTridentTupleToKafkaMapper(TridentTupleToKafkaMapper mapper) { + this.mapper = mapper; + return this; + } + + public TridentKafkaState withKafkaTopicSelector(KafkaTopicSelector selector) { + this.topicSelector = selector; + return this; + } + + @Override + public void beginCommit(Long txid) { + LOG.debug("beginCommit is Noop."); + } + + @Override + public void commit(Long txid) { + LOG.debug("commit is Noop."); + } + + public void prepare(Properties options) { + if (mapper == null) throw new NullPointerException("mapper can not be null"); --- End diff -- Objects does not exist in java 6 and I would prefer to keep the code compatible as mush as possible to avoid extra rework when pulling these changes back. If you insist I will do it.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---