[GitHub] storm pull request #2072: STORM-2477: Add generics to Config types

[srdo]

Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2072#discussion_r111682145
  
    --- Diff: 
external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/AbstractHBaseBolt.java
 ---
    @@ -51,11 +51,11 @@ public AbstractHBaseBolt(String tableName, HBaseMapper 
mapper) {
         }
     
         @Override
    -    public void prepare(Map map, TopologyContext topologyContext, 
OutputCollector collector) {
    +    public void prepare(Map topoConf, TopologyContext topologyContext, 
OutputCollector collector) {
             this.collector = collector;
             final Configuration hbConfig = HBaseConfiguration.create();
     
    -        Map<String, Object> conf = (Map<String, 
Object>)map.get(this.configKey);
    +        Map<String, Object> conf = (Map<String, 
Object>)topoConf.get(this.configKey);
    --- End diff --
    
    Won't this cast become redundant when transform.sh has been run?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---