[GitHub] storm pull request #2072: STORM-2477: Add generics to Config types

[srdo]

Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2072#discussion_r111682126
  
    --- Diff: 
storm-client/test/jvm/org/apache/storm/security/auth/AuthUtilsTest.java ---
    @@ -93,14 +93,14 @@ public void objGettersReturnNullWithNullConfigTest() 
throws IOException {
             Assert.assertNull(AuthUtils.pullConfig(null, "foo"));
             Assert.assertNull(AuthUtils.get(null, "foo", "bar"));
     
    -        Map emptyMap = new HashMap<String, String>();
    +        Map<String, Object> emptyMap = new HashMap<>();
             Assert.assertNull(AuthUtils.GetConfiguration(emptyMap));
         }
     
         @Test
         public void getAutoCredentialsTest() {
    -        Map emptyMap = new HashMap<String, String>();
    -        Map<String, Collection<String>> map = new HashMap<String, 
Collection<String>>();
    +        Map<String, Object> emptyMap = new HashMap<>();
    --- End diff --
    
    Nit: Consider replacing this with Collections.emptyMap() in L107.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---