Github user erikdw commented on a diff in the pull request:
https://github.com/apache/storm/pull/2109#discussion_r116337786
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -139,8 +139,8 @@ public void
onPartitionsRevoked(Collection<TopicPartition> partitions) {
@Override
public void onPartitionsAssigned(Collection<TopicPartition>
partitions) {
- LOG.info("Partitions reassignment. [consumer-group={},
consumer={}, topic-partitions={}]",
- kafkaSpoutConfig.getConsumerGroupId(), kafkaConsumer,
partitions);
+ LOG.info("Partitions reassignment. [task-ID={},
consumer-group={}, consumer={}, topic-partitions={}]",
--- End diff --
Minor thing, just pointing it out, though it's probably fine this way: the
"task ID" is referred to in 3 different styles in these log lines through this
PR:
* `taskId`
* `Task-ID`
* `task-ID`
I think each is consistent within their respective log lines. Just
wondering if there's any value to it being consistent across them. Also wonder
if there's any existing convention in other log lines in the code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
