Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/2100#discussion_r118366750
--- Diff:
storm-client/src/jvm/org/apache/storm/scheduler/resource/strategies/scheduling/DefaultResourceAwareStrategy.java
---
@@ -567,9 +567,9 @@ public int compare(Component o1, Component o2) {
public int compare(Component o1, Component o2) {
int connections1 = o1.execs.size() * thisComp.execs.size();
int connections2 = o2.execs.size() * thisComp.execs.size();
- if (connections1 > connections2) {
--- End diff --
hey guys this change is not right. This is suppose to sort by the number
of connections in descending order so that tasks with most connections to each
other can be attempted to be colocated first. What is the reason for this
change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
