Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2118#discussion_r118846076
--- Diff:
storm-client/src/jvm/org/apache/storm/windowing/WaterMarkEventGenerator.java ---
@@ -45,17 +46,25 @@
private final Map<GlobalStreamId, Long> streamToTs;
private final ScheduledExecutorService executorService;
private final int interval;
+ private final AtomicLong lastWaterMarkTs;
--- End diff --
Yes. Why do you prefer volatile? (I'll be happy to change it, I'm just
wondering if there's a drawback to using AtomicX)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
