Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2118#discussion_r118846518
--- Diff:
storm-client/src/jvm/org/apache/storm/windowing/WaterMarkEventGenerator.java ---
@@ -45,17 +46,25 @@
private final Map<GlobalStreamId, Long> streamToTs;
private final ScheduledExecutorService executorService;
private final int interval;
+ private final AtomicLong lastWaterMarkTs;
--- End diff --
It doesn't make much difference except the extra overhead of the AtomicLong
object and we don't require the additional atomic operations from AtomicLong.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
