Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2113#discussion_r120456638
  
    --- Diff: 
storm-server/src/test/java/org/apache/storm/scheduler/resource/TestResourceAwareScheduler.java
 ---
    @@ -46,53 +44,43 @@
     import org.slf4j.LoggerFactory;
     
     import java.util.HashMap;
    -import java.util.Iterator;
     import java.util.LinkedList;
     import java.util.List;
     import java.util.Map;
    +import java.util.Map.Entry;
     import java.util.Set;
     import java.util.ArrayList;
     import java.util.HashSet;
     import java.util.Collection;
     import java.util.Collections;
     
    -import static 
org.apache.storm.scheduler.resource.TestUtilsForResourceAwareScheduler.genExecsAndComps;
    +import static 
org.apache.storm.scheduler.resource.TestUtilsForResourceAwareScheduler.*;
     
     public class TestResourceAwareScheduler {
     
    -    private final String TOPOLOGY_SUBMITTER = "jerry";
    -
         private static final Logger LOG = 
LoggerFactory.getLogger(TestResourceAwareScheduler.class);
     
         private static int currentTime = 1450418597;
     
    -    private static final Config defaultTopologyConf = new Config();
    +    private static final Config defaultTopologyConf = 
createClusterConfig(10, 128, 0, null);
     
         @BeforeClass
         public static void initConf() {
    -        defaultTopologyConf.put(Config.STORM_NETWORK_TOPOGRAPHY_PLUGIN, 
"org.apache.storm.networktopography.DefaultRackDNSToSwitchMapping");
    -        
defaultTopologyConf.put(DaemonConfig.RESOURCE_AWARE_SCHEDULER_EVICTION_STRATEGY,
 
org.apache.storm.scheduler.resource.strategies.eviction.DefaultEvictionStrategy.class.getName());
    -        
defaultTopologyConf.put(DaemonConfig.RESOURCE_AWARE_SCHEDULER_PRIORITY_STRATEGY,
 
org.apache.storm.scheduler.resource.strategies.priority.DefaultSchedulingPriorityStrategy.class.getName());
    -
    -        defaultTopologyConf.put(Config.TOPOLOGY_SCHEDULER_STRATEGY, 
org.apache.storm.scheduler.resource.strategies.scheduling.DefaultResourceAwareStrategy.class.getName());
    -        
defaultTopologyConf.put(Config.TOPOLOGY_COMPONENT_CPU_PCORE_PERCENT, 10.0);
    -        
defaultTopologyConf.put(Config.TOPOLOGY_COMPONENT_RESOURCES_ONHEAP_MEMORY_MB, 
128.0);
    -        
defaultTopologyConf.put(Config.TOPOLOGY_COMPONENT_RESOURCES_OFFHEAP_MEMORY_MB, 
0.0);
    +      //TODO clean this up some more
    --- End diff --
    
    Todo


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to