Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2113#discussion_r120656010
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/Container.java ---
@@ -528,28 +577,108 @@ public void cleanUpForRestart() throws IOException {
deleteSavedWorkerUser();
_workerId = null;
}
-
+
+ /**
+ * Check if the container is over its memory limit AND needs to be
killed. This does not necessarily mean
+ * that it just went over the limit.
+ * @throws IOException on any error
+ */
+ public boolean isMemoryLimitViolated(LocalAssignment
withUpdatedLimits) throws IOException {
--- End diff --
Yes but it is overridden by other Container Implementations and they may
want to throw an exception.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
