Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2152#discussion_r121221199
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -104,6 +104,10 @@ public KafkaSpout(KafkaSpoutConfig<K, V>
kafkaSpoutConfig) {
this.kafkaSpoutConfig = kafkaSpoutConfig;
}
+ long getNumUncommittedOffsets() {
--- End diff --
I'm wondering if we can avoid inspecting this directly in the test by unit
testing OffsetManager instead of indirectly testing it via the KafkaSpout?
Testing that the spout will commit past gaps in the tuple stream is a good
idea, but the check of this field is actually testing that OffsetManager.commit
isn't buggy, which I feel belongs in a test for that class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
