Github user askprasanna commented on a diff in the pull request:
https://github.com/apache/storm/pull/2152#discussion_r121249114
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -104,6 +104,10 @@ public KafkaSpout(KafkaSpoutConfig<K, V>
kafkaSpoutConfig) {
this.kafkaSpoutConfig = kafkaSpoutConfig;
}
+ long getNumUncommittedOffsets() {
--- End diff --
Yes, the main purpose of the test is verifying commit behavior over offset
gaps. We can remove this getter and the asserts on it if required.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
