Github user satishd commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2241#discussion_r129218102
  
    --- Diff: 
storm-client/src/jvm/org/apache/storm/executor/ExecutorShutdown.java ---
    @@ -34,17 +34,19 @@
     import org.slf4j.Logger;
     import org.slf4j.LoggerFactory;
     
    +import java.util.ArrayList;
     import java.util.List;
     import java.util.Map;
     
     public class ExecutorShutdown implements Shutdownable, IRunningExecutor {
     
         private static final Logger LOG = 
LoggerFactory.getLogger(ExecutorShutdown.class);
    +
         private final Executor executor;
         private final List<Utils.SmartThread> threads;
    -    private final Map<Integer, Task> taskDatas;
    +    private final ArrayList<Task> taskDatas;
     
    -    public ExecutorShutdown(Executor executor, List<Utils.SmartThread> 
threads, Map<Integer, Task> taskDatas) {
    +    public ExecutorShutdown(Executor executor, List<Utils.SmartThread> 
threads, ArrayList<Task> taskDatas) {
    --- End diff --
    
    nit: taskDatas as List<Task>


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to