Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129219489
--- Diff:
storm-client/src/jvm/org/apache/storm/grouping/ShuffleGrouping.java ---
@@ -26,38 +26,25 @@
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
-import java.util.concurrent.atomic.AtomicInteger;
+
public class ShuffleGrouping implements CustomStreamGrouping, Serializable
{
- private Random random;
private ArrayList<List<Integer>> choices;
- private AtomicInteger current;
+ private int current = 0 ;
--- End diff --
You changed this to non threadsafe. Is this instance not shared by multiple
components?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
