+1 (binding)
> source - verify file (signature, MD5, SHA) -- source, tar.gz : OK -- source, zip : OK - extract file -- source, tar.gz : OK -- source, zip : OK - diff-ing extracted files between tar.gz and zip : OK - build source with JDK 7 -- source, tar.gz : OK - build source dist -- source, tar.gz : OK - build binary dist -- source, tar.gz : OK > binary - verify file (signature, MD5, SHA) -- binary, tar.gz : OK -- binary, zip : OK - extract file -- source, tar.gz : OK -- source, zip : OK - diff-ing extracted files between tar.gz and zip : OK - launch daemons : OK - run RollingTopWords (local) : OK - run RollingTopWords (remote) : OK - activate / deactivate / rebalance / kill : OK - logviewer (worker dir, daemon dir) : OK - change log level : OK - thread dump, heap dump, restart worker : OK - log search : OK - run WordCountTopology (multilang, remote) : OK Thanks, Jungtaek Lim (HeartSaVioR) 2017년 7월 26일 (수) 오전 1:11, Kishorkumar Patil <[email protected]>님이 작성: > I built and I ran manual tests. It looks good to me. > I am +1 on the release. > -Kishor > > > On Tuesday, July 25, 2017, 11:19:46 AM EDT, Bobby Evans > <[email protected]> wrote: > > I built from source (v1.0.4 a5e1c154b5b2ae74fd78bf10d4c130afb1ad4513), ran > all of the unit tests, and ran a few manual tests on my laptop. > I am +1 on the release. > > > - Bobby > > > On Tuesday, July 25, 2017, 6:27:18 AM CDT, Stig Rohde Døssing < > [email protected]> wrote: > > The linked changelog ( > https://git-wip-us.apache.org/repos/asf?p=storm.git;a= > blob_plain;f=CHANGELOG.md;h=50878fab679973a1230466920006dc0746ffddd5;hb= > eac433b0beb3798c4723deb39b3c4fad446378f4) seems to contain only changes up > to 1.0.3. It's just a problem with the link, the changelog in the src tar > is correct. > > Unpacked the binary tar to a new directory. > Started Nimbus, a supervisor and the UI daemon via the storm.cmd script. > The cluster was using the default configuration. > Unpacked the src tar, and built ExclamationTopology and the > storm-kafka-client KafkaSpoutTopologyMainNamedTopics against the Nexus > staging repository. > Submitted storm-starter ExclamationTopology > * Changed log level and verified that the log level changed > * Tried to use Logviewer, but this fails on Windows due to > "java.util.regex.PatternSyntaxException: > Unexpected internal error near index 1 > \ > ... > at org.apache.storm.daemon.logviewer$get_topo_port_ > workerlog.invoke(logviewer.clj:123)". This bug isn't new, so it's not a > blocker IMO. I think it's probably fixed on master with > https://github.com/apache/storm/pull/2204 > * Deactivated/activated and killed the topology, this worked as expected > Submitted storm-kafka-client KafkaSpoutTopologyMainNamedTopics using the > directions at https://github.com/apache/storm/tree/v1.0.4/external/ > storm-kafka-client#build-and-run-bundled-examples > <https://github.com/apache/storm/tree/v1.0.4/external/storm-kafka-client#build-and-run-bundled-examples>, > running against a local > Kafka instance. > > The topologies seemed to run fine once I got past a few Windows specific > bugs: > * https://issues.apache.org/jira/browse/STORM-2451 which has a workaround > listed on the issue. I don't know if it makes sense to pull the bugfix back > into 1.0.x? > * There's an error log when log files are rolled, seemingly due to Windows' > file locking behavior. Seems like more of an annoyance than a real issue, > since the files appear to roll correctly. The log is "STDERR Thread-2 > [INFO] 2017-07-25 13:00:45,639 Thread-5-exclaim2-executor[7 7] ERROR Unable > to delete file E:\apache-storm-1.0.4\logs\workers-artifacts\production- > topology-1-1500978841\6700\worker.log: java.nio.file.FileSystemException > E:\apache-storm-1.0.4\logs\workers-artifacts\production- > topology-1-1500978841\6700\worker.log: The process cannot access the file > because it is being used by another process." > > Other minor issues: > * Noticed in the src tar that the integration-test pom is pointing to > 1.0.3-SNAPSHOT instead of 1.0.4. This is also an issue on the 1.0.x-branch > branch on github. > * Non-HA Nimbus won't start when previously deployed topologies are not in > storm-local, giving the message "o.a.s.zookeeper main-EventThread [INFO] > code for all active topologies not available locally, giving up > leadership.". This is annoying when trying to do a rolling upgrade, since > it is easy to screw up by installing the new Storm version in a new > directory rather than overwriting the old installation. I think we should > add storm.local.dir to the comments in conf/storm.yaml and encourage people > to set it to a directory outside the storm dir. > * It looks like the blob store may be using the wrong base path when > storm.local.dir is relative. I get the directory > STORM_HOME/bin/storm-local/blobs > in addition to the expected STORM_HOME/storm-local. I'm guessing the path > is based on which working directory "storm nimbus/supervisor" is being run > from. > > I think since most of these issues have workarounds and were likely present > in 1.0.3, they shouldn't block the release. > > It might make sense to fix the integration-test pom and maybe pull > STORM-2451 back too. Since those issues are so minor I don't want to block > the release for that alone though. +1 > > 2017-07-24 20:24 GMT+02:00 P. Taylor Goetz <[email protected]>: > > > This is a call to vote on releasing Apache Storm 1.0.4 (rc1) > > > > Full list of changes in this release: > > > > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_ > > plain;f=CHANGELOG.md;h=50878fab679973a1230466920006dc0746ffddd5;hb= > > eac433b0beb3798c4723deb39b3c4fad446378f4 > > > > The tag/commit to be voted upon is v1.0.4: > > > > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_ > > plain;f=CHANGELOG.md;hb=a5e1c154b5b2ae74fd78bf10d4c130afb1ad4513 > > > > The source archive being voted upon can be found here: > > > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-1. > > 0.4-rc1/apache-storm-1.0.4-src.tar.gz > > > > Other release files, signatures and digests can be found here: > > > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-1.0.4-rc1/ > > > > The release artifacts are signed with the following key: > > > > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_ > > plain;f=KEYS;hb=22b832708295fa2c15c4f3c70ac0d2bc6fded4bd > > > > The Nexus staging repository for this release is: > > > > https://repository.apache.org/content/repositories/orgapachestorm-1048 > > > > Please vote on releasing this package as Apache Storm 1.0.4. > > > > When voting, please list the actions taken to verify the release. > > > > This vote will be open for at least 72 hours. > > > > [ ] +1 Release this package as Apache Storm 1.0.4 > > [ ] 0 No opinion > > [ ] -1 Do not release this package because... > > > > Thanks to everyone who contributed to this release. > > > > -Taylor
