Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2282#discussion_r133974197
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -73,7 +73,9 @@
// Strategy to determine the fetch offset of the first realized by the
spout upon activation
private transient FirstPollOffsetStrategy firstPollOffsetStrategy;
// Class that has the logic to handle tuple failure
- private transient KafkaSpoutRetryService retryService;
+ private transient KafkaSpoutRetryService retryService;
+ // Handles the events off a tuple
--- End diff --
Nit: Rephrase as "Handles tuple events (emit, ack etc.)", I don't think it
is clear what this means.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
