Github user bijanfahimi commented on a diff in the pull request:
https://github.com/apache/storm/pull/2282#discussion_r134125454
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaTupleListener.java
---
@@ -0,0 +1,48 @@
+package org.apache.storm.kafka.spout;
+
+import java.io.Serializable;
+import java.util.List;
+
+
+/**
+ * The KafkaTupleListener handles state changes of a kafka tuple inside a
KafkaSpout.
+ */
+public interface KafkaTupleListener extends Serializable {
--- End diff --
Good idea, I have added a prepare method or "open" since it is in the
context of a spout.
I am not sure what you mean by "dead tuples".
If `isEmitTuple(tuple)` is false in line 380 of the KafkaSpouts
`emitTupleIfNotEmitted`? But then i would have to change the onAck call as
well, since it would be called twice. I can imagine that someone needs more
callbacks. However, I tried to keep the interface simple and small. But if you
wish I would gladly add new functionality to the interface.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
