[GitHub] storm issue #2199: [STORM-2201] Add dynamic scheduler configuration loading

[Ethanlm]

Github user Ethanlm commented on the issue:

    https://github.com/apache/storm/pull/2199
  
    I am done with testing and I think this patch is ready for review. Now I 
have `ArtifactoryConfigLoader` supports both `artifactory+http` and 
`artifactory+https` schemes.
    
    @HeartSaVioR  @revans2 @jerrypeng  Could you please let me know if you have 
any suggestions on this patch when you get a chance. Thanks very much!
    
    --------
    I want to explain a bit about `Artifactory` and `ArtifactoryConfigLoader` a 
bit  if you are not familiar with the idea.
    
    To use `ArtifactoryConfigLoader`, we can set the uri pointing to a 
directory or a file on Artifactory server. 
    
    We can query the REST API `api/storage` to get the metadata of the 
artifact. If the URI (set at `scheduler.config.loader.uri` ) points to a 
directory, we can get the metadata like this:
    
![image](https://user-images.githubusercontent.com/14900612/29790336-193cdd9e-8bff-11e7-93b2-6bacc86e7266.png)
    
    We have `children` which are the files under this directory and 
`ArtifactoryConfigLoader` will pick the file with the largest lexographic name. 
    
    It the URI points to a file, the metadata will be like this:
    
![image](https://user-images.githubusercontent.com/14900612/29790339-1ce7ccf6-8bff-11e7-91d9-0133fed3af7a.png)
    
    where we can get the "downloadUri" and then download that file.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---