Github user Ethanlm commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2199#discussion_r135642230
  
    --- Diff: storm-server/src/main/java/org/apache/storm/DaemonConfig.java ---
    @@ -792,6 +792,12 @@
         public static final String ISOLATION_SCHEDULER_MACHINES = 
"isolation.scheduler.machines";
     
         /**
    +     * Configuration elements for scheduler config loader.
    +     */
    +    @isMapEntryType(keyType = String.class, valueType = String.class)
    --- End diff --
    
    You are right. I also felt that `scheduler.config.loader.params` makes 
things unnecessarily complicated. Changing it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to