Github user liu-zhaokun commented on a diff in the pull request:
https://github.com/apache/storm/pull/2297#discussion_r136278638
--- Diff:
external/storm-kafka/src/jvm/org/apache/storm/kafka/DynamicBrokersReader.java
---
@@ -110,7 +110,7 @@ private int getNumPartitions(String topic) {
List<String> children =
_curator.getChildren().forPath(topicBrokersPath);
return children.size();
} catch (Exception e) {
- throw new RuntimeException(e);
+ LOG.error(e.getMessage(), e);
--- End diff --
@HeartSaVioR
When exception is caught,we should only print the error messages,so that
users can be aware of there are some problems in their cluster such as one role
of zk was down.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
