Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2297#discussion_r136281189
--- Diff:
external/storm-kafka/src/jvm/org/apache/storm/kafka/DynamicBrokersReader.java
---
@@ -110,7 +110,7 @@ private int getNumPartitions(String topic) {
List<String> children =
_curator.getChildren().forPath(topicBrokersPath);
return children.size();
} catch (Exception e) {
- throw new RuntimeException(e);
+ LOG.error(e.getMessage(), e);
--- End diff --
When RuntimeException is propagated to call hierarchy, some place will
leave a error message. (it is guaranteed when worker is crashing)
Btw, I guess you may need to think and try to answer my questions above by
yourself.
Please note that core principal of Storm is 'fail-fast', because in many
case things are not restorable and retryable, and we had to kill the process to
prevent process to go with unexpected behavior.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
