Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2203#discussion_r140987102
  
    --- Diff: storm-core/src/jvm/org/apache/storm/task/TopologyContext.java ---
    @@ -386,4 +388,28 @@ public ReducedMetric registerMetric(String name, 
IReducer reducer, int timeBucke
         public CombinedMetric registerMetric(String name, ICombiner combiner, 
int timeBucketSizeInSecs) {
    --- End diff --
    
    +1 Let's guide using new metrics if possible.


---

Reply via email to