Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2347#discussion_r141184296
--- Diff:
external/storm-blobstore-migration/src/main/java/org/apache/storm/blobstore/ListHDFS.java
---
@@ -0,0 +1,52 @@
+package org.apache.storm.blobstore;
+
+import java.util.Map;
+
+import javax.security.auth.Subject;
+
+import org.apache.storm.Config;
+import org.apache.storm.blobstore.ClientBlobStore;
+import org.apache.storm.hdfs.blobstore.HdfsBlobStore;
+import org.apache.storm.hdfs.blobstore.HdfsClientBlobStore;
+import org.apache.storm.utils.Utils;
+
+public class ListHDFS {
+
+ public static void main(String[] args) throws Exception {
+ if(args.length < 1) {
+ System.out.println("Need at least 1 argument
(hdfs_blobstore_path), but have " + Integer.toString(args.length));
+ System.out.println("listHDFS <hdfs_blobstore_path>
<hdfs_principal> <keytab>");
+ System.out.println("Lists blobs in HdfsBlobStore");
+ System.out.println("Example: listHDFS
'hdfs://some-hdfs-namenode:8080/srv/storm/my-storm-blobstore'
'stormUser/[email protected]'
'/srv/my-keytab/stormUser.kt'");
+ System.exit(1);
+ }
+
+ Map<String, Object> hdfsConf = Utils.readStormConfig();
+ String hdfsBlobstorePath = args[0];
+
+ hdfsConf.put(Config.BLOBSTORE_DIR, hdfsBlobstorePath);
+ hdfsConf.put(Config.STORM_PRINCIPAL_TO_LOCAL_PLUGIN,
"org.apache.storm.security.auth.DefaultPrincipalToLocal");
+ if(args.length >= 2) {
+ System.out.println("SETTING HDFS PRINCIPAL!");
+ hdfsConf.put(Config.BLOBSTORE_HDFS_PRINCIPAL, args[1]);
+ }
+ if(args.length >= 3) {
+ System.out.println("SETTING HDFS KEYTAB!");
+ hdfsConf.put(Config.BLOBSTORE_HDFS_KEYTAB, args[2]);
+ }
+
+ /* CREATE THE BLOBSTORES */
+ System.out.println("Creating HDFS blobstore.");
+ HdfsBlobStore hdfsBlobStore = new HdfsBlobStore();
+ hdfsBlobStore.prepare(hdfsConf, null, null);
+ System.out.println("Done.");
--- End diff --
I'm not sure that users by default will expect the 3rd Done to mean we
really are done. Could you make the messages a bit more descriptive? or remove
them?
This goes for listing the local blobs as well.
---
