Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2347#discussion_r141183179
  
    --- Diff: external/storm-blobstore-migration/pom.xml ---
    @@ -0,0 +1,126 @@
    +<project xmlns="http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
    +         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd";>
    +    <modelVersion>4.0.0</modelVersion>
    +
    +    <parent>
    +        <artifactId>storm</artifactId>
    +        <groupId>org.apache.storm</groupId>
    +        <version>2.0.0-SNAPSHOT</version>
    +        <relativePath>../../pom.xml</relativePath>
    +    </parent>
    +    
    +    <artifactId>blobstore-migrator</artifactId>
    +    <packaging>jar</packaging>
    +    
    +    <name>blobstore-migrator</name>
    +    <url>http://maven.apache.org</url>
    +    <dependencies>
    +        <dependency>
    +            <groupId>org.apache.storm</groupId>
    +            <artifactId>storm-server</artifactId>
    +            <version>${project.version}</version>
    +            <exclusions>
    +                <!--log4j-over-slf4j must be excluded for 
hadoop-minicluster
    +                    see: http://stackoverflow.com/q/20469026/3542091 -->
    +                <exclusion>
    +                    <groupId>org.slf4j</groupId>
    +                    <artifactId>log4j-over-slf4j</artifactId>
    +                </exclusion>
    +            </exclusions>
    +        </dependency>
    +        <dependency>
    +            <groupId>org.apache.storm</groupId>
    +            <artifactId>storm-hdfs</artifactId>
    +            <version>${project.version}</version>
    +            <exclusions>
    +                <!--log4j-over-slf4j must be excluded for 
hadoop-minicluster
    +                    see: http://stackoverflow.com/q/20469026/3542091 -->
    +                <exclusion>
    +                    <groupId>org.slf4j</groupId>
    +                    <artifactId>log4j-over-slf4j</artifactId>
    +                </exclusion>
    +            </exclusions>
    +        </dependency>
    +        <!-- <dependency> -->
    +        <!--     <artifactId>storm-core</artifactId> -->
    +        <!--     <groupId>org.apache.storm</groupId> -->
    +        <!--     <version>0.10.2.y</version> -->
    +        <!-- </dependency> -->
    --- End diff --
    
    Can we remove the commented out code?


---

Reply via email to