Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r149148257
--- Diff:
storm-client/src/jvm/org/apache/storm/coordination/BatchSubtopologyBuilder.java
---
@@ -450,9 +456,33 @@ public BoltDeclarer addConfigurations(Map<String,
Object> conf) {
}
@Override
+ public Map getRASConfiguration() {
+ for (Map<String, Object> conf : _component.componentConfs) {
--- End diff --
OK so this is crazy over complicated for something that does not need all
of this complexity. I don't know why `_component.componentConfs` is a list of
maps instead of just a map because they will all be merged together in the
final component. If you could refactor it to be just a single map then life is
a lot simpler, if not then we should not be just returning a new empty hash
map, we should be adding it to the `_component.componentConfs` or it is going
to be lost.
---
