Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r149140827
--- Diff:
examples/storm-loadgen/src/main/java/org/apache/storm/loadgen/CaptureLoad.java
---
@@ -430,37 +427,39 @@ public static void main(String[] args) throws
Exception {
return topologyResources;
}
- static void checkIntialization(Map<String, Double> topologyResources,
String com,
- Map<String, Object>
topologyConf) {
- checkInitMem(topologyResources, com, topologyConf);
- checkInitCpu(topologyResources, com, topologyConf);
- }
+ /**
+ * Checks if the topology's resource requirements are initialized.
+ * @param topologyResources map of resouces requirements
--- End diff --
nit: could we add a comment that topologyResources will be modified if not
properly initialized? Just so it is clear, because that is not a typical thing
to do in a java method.
---
