Received 4 +1 binding and 1 +1 non-binding in a day, which looks consensus has been made. I will skip voting process and go ahead since Storm SQL is experimental. I'm filing issue here https://issues.apache.org/jira/browse/STORM-2845
Thanks for participating! 2017년 12월 6일 (수) 오후 12:40, Xin Wang <[email protected]>님이 작성: > +1 > > - Xin > > 2017-12-06 7:14 GMT+08:00 Hugo Da Cruz Louro <[email protected]>: > > > +1. It would just be good that once you move onto streams API this is > easy > > to test. It is highly important that we can quickly run simple tests form > > the CLI and IDE. Without that it is very hard to fix bugs, test new > > features during early developments, and come up with ways to reproduce > > users potential problems. > > > > Thanks, > > Hugo > > > > > On Dec 5, 2017, at 2:41 PM, Jungtaek Lim <[email protected]> wrote: > > > > > > Arun and Priyank, > > > > > > Yes that's how we have been having tests with trident mode, and same > > > applies on moving on streams API. > > > Btw, it doesn't mean we provide users to execute SQL in local cluster > > mode. > > > Maybe good to have that CLI feature. > > > > > > Given that we've 3 +1 (binding) including me and 1 +1 (non-binding) for > > > doing it, I'll just wait more for 8 hours (1 day from initiating > > > discussion) to open the chance to hear other opinions, and go ahead. > I'll > > > submit the PR so we may get another chance to. > > > > > > Thanks, > > > Jungtaek Lim (HeartSaVioR) > > > > > > 2017년 12월 6일 (수) 오전 5:43, P. Taylor Goetz <[email protected]>님이 작성: > > > > > >> +1 > > >> > > >> -Taylor > > >> > > >>> On Dec 5, 2017, at 2:09 PM, Priyank Shah <[email protected]> > > wrote: > > >>> > > >>> +1 (NB). As Arun mentioned, it will be good to run test it by > running > > >> topologies in local mode. > > >>> > > >>> On 12/5/17, 10:07 AM, "Arun Iyer on behalf of Arun Mahadevan" < > > >> [email protected] on behalf of [email protected]> wrote: > > >>> > > >>> +1, I don’t see much use for standalone mode other than for > testing. > > >>> > > >>> Assume we can use the storm-sql in local mode to run topologies > > >> locally without deploying to cluster ? > > >>> > > >>> Thanks, > > >>> Arun > > >>> > > >>> > > >>> > > >>> > > >>> > > >>> > > >>> On 12/4/17, 10:53 PM, "Jungtaek Lim" <[email protected]> wrote: > > >>> > > >>>> Hi devs, > > >>>> > > >>>> We have been exposing "standalone mode" of Storm SQL which leverages > > >> Storm > > >>>> SQL in a JVM process rather than composing topology and run. > > >>>> At a start we implemented both standalone and trident modes with > same > > >>>> approach, but while we improved Storm SQL by leveraging more > features > > on > > >>>> Calcite, we addressed only trident mode, and now twos are diverged. > > >>>> > > >>>> I guess there is likely no actual user on standalone mode since its > > >> classes > > >>>> are exposed but we didn't document it. I know a case, but the source > > >> codes > > >>>> on standalone mode code are migrated to the project (and modified to > > >>>> conform to the project) and the project no longer depends on Storm > > SQL. > > >>>> > > >>>> If we all don't have any other case, how about dropping it and only > > >>>> concentrate to trident mode? > > >>>> (Btw, I'm trying to replace the backend on Storm SQL from Trident to > > >>>> Streams API, which may make the mode name obsolete, but after > dropping > > >>>> standalone mode we don't even need the name for mode since there > will > > be > > >>>> only one mode.) > > >>>> > > >>>> Thanks, > > >>>> Jungtaek Lim (HeartSaVioR) > > >>> > > >>> > > >>> > > >> > > >> > > > > > > > -- > Thanks, > Xin >
