Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2203#discussion_r155643706
  
    --- Diff: 
storm-core/src/jvm/org/apache/storm/validation/ConfigValidation.java ---
    @@ -493,6 +493,46 @@ public void validateField(String name, Object o) {
             }
         }
     
    +    public static class MetricReportersValidator extends Validator {
    +
    +        @Override
    +        public void validateField(String name, Object o) {
    +            if(o == null) {
    +                return;
    +            }
    +            SimpleTypeValidator.validateField(name, Map.class, o);
    +            if(!((Map) o).containsKey("class") ) {
    --- End diff --
    
    Nit: Can we put some of these strings ('class', ''daemons' etc.) in 
constants somewhere? 


---

Reply via email to