Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r155638805
--- Diff:
storm-core/src/jvm/org/apache/storm/metrics2/reporters/ScheduledStormReporter.java
---
@@ -0,0 +1,90 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.metrics2.reporters;
+
+import com.codahale.metrics.ScheduledReporter;
+import org.apache.storm.metrics2.Metrics2Utils;
+import org.apache.storm.metrics2.filters.StormMetricsFilter;
+import org.apache.storm.utils.Utils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Map;
+import java.util.concurrent.TimeUnit;
+
+public abstract class ScheduledStormReporter implements StormReporter{
+ private static final Logger LOG =
LoggerFactory.getLogger(ScheduledStormReporter.class);
+ protected ScheduledReporter reporter;
+ protected long reportingPeriod;
+ protected TimeUnit reportingPeriodUnit;
+
+ @Override
+ public void start() {
+ if (reporter != null) {
+ LOG.debug("Starting...");
+ reporter.start(reportingPeriod, reportingPeriodUnit);
+ } else {
+ throw new IllegalStateException("Attempt to start without
preparing " + getClass().getSimpleName());
+ }
+ }
+
+ @Override
+ public void stop() {
+ if (reporter != null) {
+ LOG.debug("Stopping...");
+ reporter.stop();
+ } else {
+ throw new IllegalStateException("Attempt to stop without
preparing " + getClass().getSimpleName());
+ }
+ }
+
+
+ public static TimeUnit getReportPeriodUnit(Map<String, Object>
reporterConf) {
+ TimeUnit unit = getTimeUnitForConfig(reporterConf,
REPORT_PERIOD_UNITS);
+ return unit == null ? TimeUnit.SECONDS : unit;
--- End diff --
Does it say anywhere in the documentation that we'll default to seconds? If
not we should add a note. It would also be good to note somewhere that the
units users can use are the ones defined by TimeUnit.
---
