Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r155854567
--- Diff:
storm-core/src/jvm/org/apache/storm/metrics2/reporters/GangliaStormReporter.java
---
@@ -0,0 +1,136 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * <p/>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p/>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.metrics2.reporters;
+
+import com.codahale.metrics.ganglia.GangliaReporter;
+import com.codahale.metrics.MetricRegistry;
+import info.ganglia.gmetric4j.gmetric.GMetric;
+import org.apache.storm.daemon.metrics.MetricsUtils;
+import org.apache.storm.metrics2.filters.StormMetricsFilter;
+import org.apache.storm.utils.Utils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.Map;
+import java.util.concurrent.TimeUnit;
+
+public class GangliaStormReporter extends ScheduledStormReporter {
+ private final static Logger LOG =
LoggerFactory.getLogger(GangliaStormReporter.class);
+
+ public static final String GANGLIA_HOST = "ganglia.host";
+ public static final String GANGLIA_PORT = "ganglia.port";
+ public static final String GANGLIA_PREFIXED_WITH =
"ganglia.prefixed.with";
+ public static final String GANGLIA_DMAX = "ganglia.dmax";
+ public static final String GANGLIA_TMAX = "ganglia.tmax";
+ public static final String GANGLIA_UDP_ADDRESSING_MODE =
"ganglia.udp.addressing.mode";
+ public static final String GANGLIA_RATE_UNIT = "ganglia.rate.unit";
+ public static final String GANGLIA_DURATION_UNIT =
"ganglia.duration.unit";
+ public static final String GANGLIA_TTL = "ganglia.ttl";
+ public static final String GANGLIA_UDP_GROUP = "ganglia.udp.group";
+
+ @Override
+ public void prepare(MetricRegistry metricsRegistry, Map stormConf, Map
reporterConf) {
+ LOG.debug("Preparing...");
+ GangliaReporter.Builder builder =
GangliaReporter.forRegistry(metricsRegistry);
+
+ TimeUnit durationUnit =
MetricsUtils.getMetricsDurationUnit(reporterConf);
+ if (durationUnit != null) {
+ builder.convertDurationsTo(durationUnit);
+ }
+
+ TimeUnit rateUnit = MetricsUtils.getMetricsRateUnit(reporterConf);
+ if (rateUnit != null) {
+ builder.convertRatesTo(rateUnit);
+ }
+
+ StormMetricsFilter filter = getMetricsFilter(reporterConf);
+ if(filter != null){
+ builder.filter(filter);
+ }
+ String prefix = getMetricsPrefixedWith(reporterConf);
+ if (prefix != null) {
+ builder.prefixedWith(prefix);
+ }
+
+ Integer dmax = getGangliaDMax(reporterConf);
+ if (prefix != null) {
+ builder.withDMax(dmax);
+ }
+
+ Integer tmax = getGangliaTMax(reporterConf);
+ if (prefix != null) {
+ builder.withTMax(tmax);
+ }
+
+ //defaults to 10
+ reportingPeriod = getReportPeriod(reporterConf);
+
+ //defaults to seconds
+ reportingPeriodUnit = getReportPeriodUnit(reporterConf);
+
+ // Not exposed:
--- End diff --
It means the `GangliaReporter.Builder.withClock` method is not
exposed/setable by the storm configuration. I'll remove it.
---
