[GitHub] storm pull request #2465: STORM-2844: KafkaSpout Throws IllegalStateExceptio...

[srdo]

Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2465#discussion_r157362307
  
    --- Diff: 
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
 ---
    @@ -134,7 +134,12 @@ public KafkaSpoutConfig(Builder<K, V> builder) {
             EARLIEST,
             LATEST,
             UNCOMMITTED_EARLIEST,
    -        UNCOMMITTED_LATEST
    +        UNCOMMITTED_LATEST;
    +
    +        @Override
    +        public String toString() {
    +            return "FirstPollOffsetStrategy{" + super.toString() + "}";
    --- End diff --
    
    This seems a little unnecessary, enums already have a good toString 
implementation?


---