Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157350384
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -225,6 +237,23 @@ private long doSeek(TopicPartition tp,
OffsetAndMetadata committedOffset) {
}
}
+ /**
+ * Checks If {@link OffsetAndMetadata} was committed by this topology,
either by this or another spout instance.
--- End diff --
Great. We might still want to expand the javadoc for the constants in
KafkaSpoutConfig, because right now it doesn't say anything about when the
setting has an effect, just that it applies to "the first poll".
---
