Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r158677275
--- Diff:
storm-client/src/jvm/org/apache/storm/trident/spout/RichSpoutBatchExecutor.java
---
@@ -194,7 +194,12 @@ public void reportError(Throwable t) {
public void emitDirect(int task, String stream, List<Object>
values, Object id) {
throw new UnsupportedOperationException("Trident does not
support direct streams");
}
-
+
+ @Override
+ public void flush() {
+ //NOOP //TODO: Roshan: validate if this is OK
--- End diff --
Please remove TODO if it is addressed, or address this before merging.
---
