Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2241#discussion_r158679244
  
    --- Diff: storm-client/src/jvm/org/apache/storm/utils/Utils.java ---
    @@ -1505,4 +1507,20 @@ public static StormTopology 
addVersions(StormTopology topology) {
             }
             return defaultsConf;
         }
    +
    +    public static <V> ArrayList<V> convertToArray(Map<Integer, V> srcMap, 
int start) {
    +        Set<Integer> executorIds = srcMap.keySet();
    --- End diff --
    
    Let's use more generic variable name: ids would be enough.


---

Reply via email to