[GitHub] storm pull request #2467: STORM-2860: Add Kerberos support to Solr bolt

[hmcl]

Github user hmcl commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2467#discussion_r159120398
  
    --- Diff: 
external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java
 ---
    @@ -153,4 +160,15 @@ private void failQueuedTuples(List<Tuple> 
failedTuples) {
         @Override
         public void declareOutputFields(OutputFieldsDeclarer declarer) { }
     
    +    @Override
    +    public void cleanup() {
    +        if (solrClient != null) {
    +            try {
    +                solrClient.close();
    +            } catch (IOException e) {
    +                LOG.debug("Error while closing solrClient", e);
    --- End diff --
    
    should it be error level?


---