Github user satishd commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2467#discussion_r158912237
  
    --- Diff: 
external/storm-solr/src/main/java/org/apache/storm/solr/mapper/SolrMapper.java 
---
    @@ -26,6 +26,7 @@
     import java.util.List;
     
     public interface SolrMapper extends Serializable {
    +    void configure();
    --- End diff --
    
    @HeartSaVioR  Suggested approach looks practical to me. If there are 
requests for this issue to be fixed in 1.x then new interfaces can be 
introduced without changing existing interfaces and make respective code 
changes which support both old and new semantics.


---

Reply via email to